Identify RTM-LAMP temperature and voltage sensors #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align `attr` fields with the SDR structures of the RTM-LAMP LM75 temperature sensors to indicate which part of the card is being monitored Also add support for MAX11609-based housekeeping voltage sensors on the RTM-LAMP
gustavosr8
reviewed
May 9, 2025
Comment on lines
+36
to
+46
| { TempAirIn, 1 , 1 , $(fruid), alias_$(dev), $(dev) } | ||
| { TempAirOut, 2 , 1 , $(fruid), alias_$(dev), $(dev) } | ||
| { TempPSBlock, 3, 1 , $(fruid), alias_$(dev), $(dev) } | ||
| { VoltVS1, 1 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { VoltVS2, 2 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { VoltN7V, 3 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { Volt7V, 4 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { Volt2V5, 5 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { Volt3V3, 6 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { Volt5V, 7 , 2 , $(fruid), alias_$(dev), $(dev) } | ||
| { Volt12V_HP, 8 , 2 , $(fruid), alias_$(dev), $(dev) } |
There was a problem hiding this comment.
Please, keep the items aligned in the attr column.
Suggested change
| { TempAirIn, 1 , 1 , $(fruid), alias_$(dev), $(dev) } | |
| { TempAirOut, 2 , 1 , $(fruid), alias_$(dev), $(dev) } | |
| { TempPSBlock, 3, 1 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltVS1, 1 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltVS2, 2 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltN7V, 3 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt7V, 4 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt2V5, 5 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt3V3, 6 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt5V, 7 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt12V_HP, 8 , 2 , $(fruid), alias_$(dev), $(dev) } | |
| { TempAirIn, 1, 1 , $(fruid), alias_$(dev), $(dev) } | |
| { TempAirOut, 2, 1 , $(fruid), alias_$(dev), $(dev) } | |
| { TempPSBlock, 3, 1 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltVS1, 1, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltVS2, 2, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { VoltN7V, 3, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt7V, 4, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt2V5, 5, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt3V3, 6, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt5V, 7, 2 , $(fruid), alias_$(dev), $(dev) } | |
| { Volt12V_HP, 8, 2 , $(fruid), alias_$(dev), $(dev) } | |
| #------------------------------------------------------------------ | ||
|
|
||
|
|
|
This changes refers to a specif (yet unreleased) openMMC version and only should be merged when the new release comes up, IMO. The commit message should also refer to it. Maybe something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
attrfields with the SDR structures of the RTM-LAMP LM75 temperature sensors to indicate which part of the card is being monitoredAlso add support for MAX11609-based housekeeping voltage sensors on the RTM-LAMP